Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #131 login screen text #135

Merged
merged 9 commits into from
Nov 3, 2024
Merged

fix #131 login screen text #135

merged 9 commits into from
Nov 3, 2024

Conversation

Basler182
Copy link
Contributor

@Basler182 Basler182 commented Oct 27, 2024

login screen text

♻️ Current situation & Problem

#131

⚙️ Release Notes

the exact text is not yet known, but PR is already preparing it in order to integrate the change as quickly and easily as possible.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Signed-off-by: Basler182 <showdialog@web.de>
@Basler182 Basler182 added the ENGAGE HF ENGAGE-HF-specific issues label Oct 27, 2024
@Basler182 Basler182 self-assigned this Oct 27, 2024
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 24 lines in your changes missing coverage. Please review.

Project coverage is 39.47%. Comparing base (dc72363) to head (bae70fd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...stanford/spezi/module/account/login/LoginScreen.kt 0.00% 24 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #135      +/-   ##
============================================
- Coverage     39.49%   39.47%   -0.02%     
- Complexity      784      785       +1     
============================================
  Files           265      265              
  Lines         10494    10524      +30     
  Branches       1473     1476       +3     
============================================
+ Hits           4144     4153       +9     
- Misses         5989     6010      +21     
  Partials        361      361              
Flag Coverage Δ
uitests 33.57% <ø> (ø)
unittests 33.31% <27.28%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nford/spezi/module/account/login/LoginViewModel.kt 90.10% <100.00%> (+0.77%) ⬆️
...edu/stanford/spezi/module/account/login/UiState.kt 92.86% <100.00%> (+0.55%) ⬆️
...stanford/spezi/module/account/login/LoginScreen.kt 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc72363...bae70fd. Read the comment docs.

@Basler182 Basler182 marked this pull request as ready for review October 29, 2024 18:38
@Basler182 Basler182 linked an issue Nov 1, 2024 that may be closed by this pull request
1 task
Signed-off-by: Basler182 <showdialog@web.de>
@Basler182 Basler182 requested a review from eldcn November 2, 2024 09:16
Copy link
Contributor

@eldcn eldcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good 🚀 Let me know whether I should address the comment or whether you can push it

@Basler182 Basler182 merged commit 891883b into main Nov 3, 2024
11 checks passed
@Basler182 Basler182 deleted the task/login-screen-text branch November 3, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENGAGE HF ENGAGE-HF-specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Login Screen Text
2 participants